Repository navigation
feat(ocm): sign responses with request binding - #66633
Open
mickenordin wants to merge 2 commits into
Open
mickenordin wants to merge 2 commits into
mickenordin wants to merge 2 commits into
Conversation
mickenordin
requested review from
icewind1991 and
provokateurin
and removed request for
a team
November 15, 2026 22:14
mickenordin
force-pushed
the
kano-sign-response
branch
from
November 15, 2026 22:15
0376579 to
7a8ffbf
Compare
mickenordin
marked this pull request as draft
November 15, 2026 22:58
mickenordin
force-pushed
the
kano-sign-response
branch
2 times, most recently
from
November 16, 2026 10:25
19ae1e9 to
33a474e
Compare
mickenordin
marked this pull request as ready for review
November 16, 2026 10:25
Contributor
Author
|
This is the result: This was produced by: https://code.smolnet.org/micke/federated_groups |
This was referenced Nov 16, 2026
mickenordin
force-pushed
the
kano-sign-response
branch
from
November 16, 2026 12:59
33a474e to
56488ce
Compare
Member
|
Forgot to add my review comment. I ran an AI review on the PR looks mostly good, but it reads like there are some bugs that should be addressed before merging |
Contributor
Author
I will address these findings! |
Assisted-by: OpenCode:gpt-daybreak-blue-latest Signed-off-by: Micke Nordin <kano@sunet.se>
mickenordin
force-pushed
the
kano-sign-response
branch
from
November 17, 2026 18:56
56488ce to
dc7c2b1
Compare
- throw SignatureException (400 + throttle) instead of
InvalidArgumentException (500) on malformed component identifiers
- bind responses to the request via "signature";key="ocm";req and cover
only the ocm entry of Signature-Input ("signature-input";key="ocm";req)
- sign lazily at send time and re-sign when status/headers change
- allow signing non-200/non-JSON responses via status/contentType params
- share target-uri reconstruction and signing logic in SignatureBase
Assisted-by: OpenCode:mistral-large-latest
Signed-off-by: Micke Nordin <kano@sunet.se>
Contributor
Author
|
I think it should be fixed now. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the ability to sign responses with RFC9421 signatures. This is required for federated groups. As such it works together with: #66049 that also adds a foundational piece for federated groups as well as #66642. In particular, the key package of OCM-MLS endpoint needs to sign responses.
Checklist
3. to review, feature component)stable32)AI (if applicable)